Add --prefix option to build-for-compare.py for passing a depends prefix to ./configure #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
commented
Aug 1, 2019
cbbf228 to
508393b
Compare
|
Updated to only pass |
|
Tested ACK 508393b |
laanwj
added a commit
that referenced
this pull request
Aug 1, 2019
…depends prefix to ./configure 508393b misc Python cleanups (fanquake) 7b0369a Add option to pass a depends prefix to ./configure (fanquake) b111689 Update stripbuildinfo.patch to apply cleanly to master (fanquake) Pull request description: When doing build comparisons I'd like to be able to pass a depends prefix to `./configure`. This is not only useful for testing PRs such as bitcoin/bitcoin#16370, but also when I don't want to install dependencies and would rather just build them using depends. This also updates the `stripbuildinfo.patch` to apply cleanly (bitcoin/bitcoin@25f0edd). As well as some misc Python improvements, which can be dropped if required. Example use: ```bash ../bitcoin-maintainer-tools/build-for-compare.py \ b7fbf74b980ebb122ae34b142f2cc49b44b92de3 \ 25f0edd59fee454495da39c6c63f19b97cd75e96 \ --prefix=/bitcoin/depends/x86_64-pc-linux-gnu \ --executables=src/bitcoind,src/qt/bitcoin-qt \ --parallelism=5 ``` ACKs for top commit: laanwj: Tested ACK 508393b Tree-SHA512: 1236d632563d9ddda548b150be191d1c5a18f3eaaef12c7173d09aefe41a73686bcb40d888074ef82e96b5ae1beb8ad9fd2f469e2f0deca93ddf1af52640e46b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing build comparisons I'd like to be able to pass a depends prefix to
./configure. This is not only useful for testing PRs such as bitcoin/bitcoin#16370, but also when I don't want to install dependencies and would rather just build them using depends.This also updates the
stripbuildinfo.patchto apply cleanly (bitcoin/bitcoin@25f0edd).As well as some misc Python improvements, which can be dropped if required.
Example use:
../bitcoin-maintainer-tools/build-for-compare.py \ b7fbf74b980ebb122ae34b142f2cc49b44b92de3 \ 25f0edd59fee454495da39c6c63f19b97cd75e96 \ --prefix=/bitcoin/depends/x86_64-pc-linux-gnu \ --executables=src/bitcoind,src/qt/bitcoin-qt \ --parallelism=5