update-translations: Generate ts_files.cmake with explicit .ts files list #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Will review it shortly. |
hebasto
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
ACK 2c67395.
I actually prefer the alternative ts_files.cmake file location you noted in your comment:
# Generate ts_files.cmake with an explicit list of .ts files in src/qt/locale
It offers a few advantages, such as:
- a more readable and cleaner
ts_files.cmake; - a scoped
ts_filesvariable; - improved code locality;
- no need to adjust the location of
*.qmfiles.
See a working branch here.
|
Thought you might be interested in taking a look at this PR. |
2c67395 to
ebad2b0
Compare
|
@hebasto thanks for looking at the PR. I have updated the PR to include you suggestions i.e moved to |
|
Post-merge ACK ebad2b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bitcoin/bitcoin#32653 (first part)
Generate
ts_files.cmakefile which contains an explicit list of.tsfiles insrc/qt/localeto be used bysrc/qt/CMakeList.txt