fastcopy-chaindata: Leveldb file numbers can exceed 6 digits #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For long-running instances, leveldb file numbers can go on beyond 6 digits. Adapt the regexp to this.
|
CR ACK for a29e014 This seems to work well for files with additional digits. Just a minor nit. Technically, without escaping the period in the regex, files with a character other than period match. Not sure if we care to make this a more strict regex given its scope of use and the likely contents of the directory. If so, it would be a separate PR than this one. >>> fnames = {'six_digit':'123456.ldb', 'seven_digit':'9123456.ldb', 'six_digit_not_period':'123456!ldb', 'seven_digit_not_period':'9123456!ldb', 'eight_digit':'89123456.ldb'}
>>> for f in fnames:
... if re.match('^[0-9]{6}.ldb$', fnames[f]):
... print(f, 'matched the regex')
... else:
... print(f, 'didn\'t match the regex')
...
six_digit matched the regex
seven_digit didn't match the regex
six_digit_not_period matched the regex
seven_digit_not_period didn't match the regex
eight_digit didn't match the regex
>>> for f in fnames:
... if re.match('^[0-9]{6,}.ldb$', fnames[f]):
... print(f, 'matched the regex')
... else:
... print(f, 'didn\'t match the regex')
...
six_digit matched the regex
seven_digit matched the regex
six_digit_not_period matched the regex
seven_digit_not_period matched the regex
eight_digit matched the regex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For long-running instances, leveldb file numbers can go on beyond 6 digits. Adapt the regexp to this.