Make update-translations.py work with XLIFF Transifex translations #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that conversion from XLIFF format to Qt's TS is not enough for correct update translation files in the main repo.
The problem is that the
approved
attributes of the<trans-unit>
tags of XLIFF translation files fetched from Transifex do not follow the actual status of a messages: neither "translated:yes/no", nor "reviewed:yes/no".Every new translatable message in the code, after
make translate
ends in thebitcoin_en.ts
with an empty elementand in the
bitcoin_en.xlf
withoutapproved="yes"
.And those attributes--
type="unfinished"
and absence ofapproved="yes"
--are inherited by the fetched XLIFF translation files and the converted TS files.Ignoring the
type="unfinished"
attribute seems the easiest way to cope with this issue.