ci: Always run test #743
Merged
ci: Always run test #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always run test jobs even if sim-builder fails as some sims should always build and we should run the tests for those.
445dbc9 to
edab2af
Compare
|
Can you explain what problem this was solving? This leads to confusing error messages. E.g. in https://github.com/bitcoin-core/HWI/actions/runs/16439653752/job/46457782189 fails with "tail: cannot open 'test/.std' for reading: No such file or directory", which happens because earlier in the job it failed to download an artifact, because the builder job was cancelled. I also suspect it interacts badly with |
If one simulator failed to build, none of the tests would run, even if the simulator for that device did build. This was to let those tasks run so one simulator build failure did not cause CI to be useless. |
|
Ah I see. Maybe the trick is to split into one group per device? |
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 22, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
|
Taking a stab at this in #797. |
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 22, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 23, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 24, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 24, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 24, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 24, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 24, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 24, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Jul 24, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Aug 12, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sjors
added a commit
to Sjors/HWI
that referenced
this pull request
Aug 30, 2025
This ensures the failure to build a simulator for one device doesn't abort running jobs for the others. They're still grouped by manufacturer. Alternative to bitcoin-core#743.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always run test jobs even if sim-builder fails as some sims should always build and we should run the tests for those.