Several configurations failed. Can you have a look?

Mmm weird. Only the debug builds for version 2.2 are failing. I'm gonna pin @eliasdaler just in case

It fails here for Debug Shared (Debug Static is ok) builds:

2021-03-04T15:57:32.1507249Z [100%] Linking CXX shared library ../lib/libImGui-SFML_d.so
2021-03-04T15:57:32.1870741Z /usr/bin/ld: cannot find -lsfml-graphics
2021-03-04T15:57:32.1872538Z /usr/bin/ld: cannot find -lsfml-system
2021-03-04T15:57:32.1873859Z /usr/bin/ld: cannot find -lsfml-window

Pretty strange.

Maybe adding DEBUG_POSTFIX broke something. It was only applied for shared libs for some reason.

Can you temporarily point Conan to this commit? SFML/imgui-sfml@f35da32

1. Try it as-is and see if CI passes. It can potentially break more stuff (now only debug shared libs are broken), but it'll be good to investigate WHY it happens, because I don't see why adding a debug postfix leads to SFML libs not being found.
2. If it still fails, try to set IMGUI_SFML_DEBUG_POSTFIX to an empty string

Okay, I'm adding a version that points to the specific commit and remove the 2.2 version. Let's see what happens

The CI still ran with 2.2, looks like

And if I change the sources under the 2.2 version (using the ones in the commit instead of the 2.2 ones), the recipe fails to be created. I'm not sure how to test your specific commit. Maybe with a patch file?

Yeah, patch file should work

And if I change the sources under the 2.2 version (using the ones in the commit instead of the 2.2 ones), the recipe fails to be created

Have you changed the URL in conandata.yml and changed the source() method in conanfile.py to successfully extract from the new top-level directory within the download?

Have you changed the URL in conandata.yml and changed the source() method in conanfile.py to successfully extract from the new top-level directory within the download?

I actually tried changing the URL to the specific commit in the conandata.yml, but with no luck. I then looked into the source() function, but I couldn't figure it out neither after trying changing the call to tools.get().

It seems that, the way it's done, it doesn't like when the version number doesn't appear in the URL. Maybe there's something I'm not considering, or at least there should be a workaround for it.

This should allow to test the commit in CI

a04d9ca

It seems the CI is still broken with that specific commit @eliasdaler

I'm not sure it's a problem of ImGui-SFML's CMake... Can you reproduce it locally? It's pretty strange that CMake is not able to find SFML's libs - maybe SFML Conan recipe is not functioning correctly?

I'm lately running a little bit out of time, so if you feel like closing this PR to further investigate what's going on, please do it so.

Are there any plans for looking into this? I am eager to update to newer versions of imgui and the SFML binding, especially for some bugfixes.

Are there any plans for looking into this? I am eager to update to newer versions of imgui and the SFML binding, especially for some bugfixes.

I guess, but now it has to target 2.3. Also, as I said, I don't have much time to look into this, and the CI keeps failing for some reason in Debug builds for the latest version. As soon as that is fixed, this should be easy to merge.

retrigger CI

2.3 came out some time ago, so maybe we should add it too

Don't hesitate to do so. Also, don't forget to add the patch in config.yml (the same patch as 2.2 should work, because there was no change on this part of the CMakeLists, nor in line numbers)

2.3 builds fail because of ocornut/imgui#4171. It seems the only way to solve this is to set cmake option IMGUI_SFML_IMGUI_DEMO=True, or wait until the next release

2.3 builds fail because of ocornut/imgui#4171. It seems the only way to solve this is to set cmake option IMGUI_SFML_IMGUI_DEMO=True, or wait until the next release

At this point, it seems easier to just wait until the next release, as Dear ImGui tends to release every 2 months or so (unless it is a big release, like 1.80 was)

I was on vacation and completely missed your delete suggestions. I think this is the best move until we can add ImGui-SFML 2.3. Thanks for the work!

No problem, don't worry!