Skip to content

add gcc 10, clang 10 and clang 11 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2021
Merged

add gcc 10, clang 10 and clang 11 #30

merged 2 commits into from
Mar 23, 2021

Conversation

ericLemanissier
Copy link
Contributor

No description provided.

@ericLemanissier ericLemanissier requested a review from Croydon May 29, 2020 19:44
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020 •
edited
Loading

Codecov Report

Merging #30 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #30   +/-   ##
========================================
  Coverage    57.02%   57.02%           
========================================
  Files           12       12           
  Lines          349      349           
========================================
  Hits           199      199           
  Misses         150      150
Impacted Files Coverage Δ
bincrafters/generate_ci_jobs.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2283841...56e837c. Read the comment docs.

@Croydon
Copy link
Member

Croydon commented May 29, 2020

Should we wait until CCI adds builds for those compilers? If we merge now most build jobs will fail because of missing binaries

@ericLemanissier
Copy link
Contributor Author

Yes, clearly. My fingers did this PR in autopilot, my brain is long asleep because it's Friday evening !

@Croydon Croydon self-assigned this May 29, 2020
@Croydon Croydon force-pushed the develop branch 4 times, most recently from f978485 to 8702da1 Compare October 28, 2020 13:25
@ericLemanissier
Copy link
Contributor Author

I also added clang 11 and apple-clang 12. I'm not sure which configuration has to be removed

@ericLemanissier ericLemanissier requested a review from Croydon March 22, 2021 18:11
@Croydon Croydon changed the title add gcc and clang 10 add gcc 10, clang 10 and clang 11 Mar 22, 2021
@Croydon
Copy link
Member

Croydon commented Mar 22, 2021

Let's not remove anything right now, but rather wait until our infrastructure / resources are clear and CCI decides too what configurations they support

@Croydon
Copy link
Member

Croydon commented Mar 22, 2021

There are merge conflicts

@ericLemanissier
Copy link
Contributor Author

really ? Github tells me This branch has no conflicts with the base branch and shows me the "merge pull request" button ?

@Croydon
Copy link
Member

Croydon commented Mar 23, 2021 •
edited
Loading 

This branch cannot be rebased due to conflicts
Rebasing the commits of this branch on top of the base branch cannot be performed automatically due to conflicts encountered while reapplying the individual commits from the head branch.

Merging is possible, but not rebasing. Interesting

@Croydon Croydon merged commit 465aa6f into develop Mar 23, 2021
@ericLemanissier ericLemanissier deleted the ericLemanissier-patch-1 branch March 23, 2021 15:14
Croydon pushed a commit that referenced this pull request Oct 3, 2021
@ericLemanissier @Croydon
add gcc 10, clang 10 and clang 11 to build matrix (#30)
84171fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Croydon Croydon Awaiting requested review from Croydon

Assignees

@Croydon Croydon

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericLemanissier @codecov-commenter @Croydon