Skip to content

Conversation

peterjc
Copy link
Member

@peterjc peterjc commented May 9, 2020

See psf/black#709 and PyCQA/pydocstyle#395 - pydocstyle v5.0.0 (and thus flake8 D202) was relaxed to accept the blank lines added by black.

  • I hereby agree to dual licence this and any previous contributions under both
    the Biopython License Agreement AND the BSD 3-Clause License.

  • I have read the CONTRIBUTING.rst file, have run flake8 locally, and
    understand that AppVeyor and TravisCI will be used to confirm the Biopython unit
    tests and style checks pass with these changes.

  • I have added my name to the alphabetical contributors listings in the files
    NEWS.rst and CONTRIB.rst as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

See psf/black#709 and
PyCQA/pydocstyle#395

pydocstyle v5.0.0 (and thus flake8 D202) was
relaxed to accept the blank lines added by black.
@peterjc peterjc requested review from bow, etal and JoaoRodrigues as code owners May 9, 2020 15:59
@peterjc
Copy link
Member Author

peterjc commented May 9, 2020

Looks like I should fix the comment to be PyCQA/pydocstyle#426 instead

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #2870 into master will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2870      +/-   ##
==========================================
+ Coverage   83.75%   84.18%   +0.43%     
==========================================
  Files         318      318              
  Lines       49936    50126     +190     
==========================================
+ Hits        41822    42201     +379     
+ Misses       8114     7925     -189     
Impacted Files Coverage Δ
Bio/KEGG/KGML/KGML_parser.py 80.00% <ø> (ø)
Bio/Nexus/Nexus.py 71.78% <ø> (ø)
Bio/Nexus/Trees.py 79.78% <ø> (ø)
Bio/Phylo/BaseTree.py 89.15% <ø> (+0.10%) ⬆️
Bio/Phylo/PhyloXML.py 81.08% <ø> (+0.14%) ⬆️
Bio/Phylo/PhyloXMLIO.py 89.97% <ø> (ø)
Bio/PopGen/GenePop/__init__.py 79.31% <ø> (ø)
Bio/Restriction/Restriction.py 84.49% <ø> (+1.33%) ⬆️
Bio/SearchIO/HHsuiteIO/hhsuite2_text.py 97.01% <ø> (+0.02%) ⬆️
Bio/SearchIO/__init__.py 89.04% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9873894...8349d7c. Read the comment docs.

@peterjc peterjc merged commit ae58ce2 into biopython:master May 9, 2020
@peterjc peterjc deleted the d202_comments branch May 9, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant