Skip to content

fix build with cmake 4 #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix build with cmake 4 #508

merged 1 commit into from
Mar 27, 2025

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Mar 25, 2025

Fixes #505

@codecov Codecov
Copy link

codecov bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (fa8aebb) to head (4168dbf).
Report is 14 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          34       34           
  Lines       11507    11507           
=======================================
  Hits        11205    11205           
  Misses        302      302

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@biojppm biojppm force-pushed the fix/505_cmake4 branch 3 times, most recently from f121fe4 to d27170b Compare March 25, 2025 22:45
@coveralls
Copy link

coveralls commented Mar 26, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14094755778

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.586%
Totals Coverage Status
Change from base Build 14072261368: 0.0%
Covered Lines: 11602
Relevant Lines: 11889
💛 - Coveralls

@biojppm biojppm force-pushed the fix/505_cmake4 branch 4 times, most recently from 3d4f6e3 to 32ff6b0 Compare March 26, 2025 21:11
@biojppm biojppm merged commit 6738c85 into master Mar 27, 2025
257 checks passed
@biojppm biojppm deleted the fix/505_cmake4 branch March 27, 2025 00:14
LecrisUT
LecrisUT reviewed Mar 27, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LecrisUT LecrisUT LecrisUT left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build tests with CMake 4.0
3 participants
@biojppm @coveralls @LecrisUT