Fix deserialization of empty strings #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32cda18 to
e29771c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 97.27% 97.30% +0.02%
==========================================
Files 34 34
Lines 11285 11322 +37
==========================================
+ Hits 10978 11017 +39
+ Misses 307 305 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dc481d1 to
75dfe1a
Compare
dabb6af to
b8cdc8f
Compare
- Deserializing an empty quoted string *will not* cause an error. Previously, this was causing an error. - Deserializing an empty string *will* cause an error. - Ensure keys are deserialized using all the rules applying to vals: add readkey() analogs to read(). - Added `KEYNIL` and `VALNIL` to `NodeType_e`, used by the parser to mark the key or val as empty. This changed the values of the `NodeType_e` enumeration. - Added `NodeType::key_is_null()` and `NodeType::val_is_null()`.
b8cdc8f to
8b988dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480
KEYNILandVALNILtoNodeType_e, used by the parser to mark the key or val as empty. This changed the values of theNodeType_eenumeration.