Skip to content

improve complexity of has_sibling() and has_child() #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Nov 18, 2022

fixes #329

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #330 (4af0ac3) into master (a3e646f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   96.49%   96.48%   -0.01%     
==========================================
  Files          22       22              
  Lines        8064     8075      +11     
==========================================
+ Hits         7781     7791      +10     
- Misses        283      284       +1     
Impacted Files Coverage Δ
src/c4/yml/tree.cpp 94.94% <100.00%> (-0.06%) ⬇️
src/c4/yml/tree.hpp 98.98% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@biojppm biojppm merged commit a69a353 into master Nov 21, 2022
@biojppm biojppm deleted the fix/has_sibling branch November 21, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

has_sibling() is inefficient
1 participant