Skip to content

Don't override key type_bits when copying val #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

NaN-git
Copy link

@NaN-git NaN-git commented Dec 5, 2022

A test case like in #268 should be added, too. Done

Fixes #268

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #339 (4edfdaa) into master (10c2fe1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4edfdaa differs from pull request most recent head e38d4bc. Consider uploading reports for the commit e38d4bc to get more accurate results

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   96.45%   96.45%   -0.01%     
==========================================
  Files          22       22              
  Lines        8068     8062       -6     
==========================================
- Hits         7782     7776       -6     
  Misses        286      286              
Impacted Files Coverage Δ
src/c4/yml/tree.hpp 98.96% <100.00%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NaN-git NaN-git force-pushed the fix-copy-props branch 2 times, most recently from 2bfb4c9 to 0f93309 Compare December 5, 2022 23:52
@biojppm biojppm merged commit b80d023 into biojppm:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anchor in sequence dereferenced in a map fail, replaced by a scalar.
2 participants