Skip to content

Conversation

NaN-git
Copy link

@NaN-git NaN-git commented Dec 2, 2022

Empty lines in block scalars cannot contain a \t-character.

All non-failing YAML parsers on YAML playground do not recognize the \t-character as part of an empty line, too.

Fixes #337

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #338 (b25f371) into master (94d7bbd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files          22       22           
  Lines        8068     8068           
=======================================
  Hits         7782     7782           
  Misses        286      286           
Impacted Files Coverage Δ
src/c4/yml/parse.cpp 95.67% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@biojppm biojppm merged commit 10c2fe1 into biojppm:master Dec 3, 2022
@biojppm
Copy link
Owner

biojppm commented Dec 3, 2022

@NaN-git thanks! This is really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially incorrect empty line detection in Parse::_filter_block_scalar
2 participants