Skip to content

[fix] emitted scalars containing @ should be quoted #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Sep 27, 2022

fixes #309

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #310 (5d0243b) into master (57429fc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          22       22           
  Lines        7986     7986           
=======================================
  Hits         7695     7695           
  Misses        291      291           
Impacted Files Coverage Δ
src/c4/yml/emit.def.hpp 92.19% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it is already covered, I don't see the backtick in the list, it also has to be quoted

@biojppm
Copy link
Owner Author

biojppm commented Sep 27, 2022

@perlpunk thanks for the note. indeed backtick was also missing.

@biojppm biojppm merged commit 78b3765 into master Sep 27, 2022
@biojppm biojppm deleted the fix/emit_at_309 branch September 27, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicator character emitted as plain scalar unexpectedly
2 participants