Skip to content

NodeRef: const overloads did not participate in overload resolution #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Aug 18, 2022

fixes #294

@biojppm biojppm force-pushed the fix/crtp_overloads branch 2 times, most recently from d3e7bc4 to 665469e Compare August 18, 2022 02:50
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #295 (665469e) into master (8123e33) will increase coverage by 0.00%.
The diff coverage is 97.64%.

❗ Current head 665469e differs from pull request most recent head d07f4f0. Consider uploading reports for the commit d07f4f0 to get more accurate results

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          78       78           
  Lines       17757    17820   +63     
=======================================
+ Hits        17253    17315   +62     
- Misses        504      505    +1     
Impacted Files Coverage Δ
src/c4/yml/node.hpp 97.14% <94.73%> (-0.18%) ⬇️
test/test_noderef.cpp 99.39% <100.00%> (+0.09%) ⬆️
src/c4/yml/tree.hpp 98.93% <0.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@biojppm biojppm force-pushed the fix/crtp_overloads branch from 3bcfc34 to d07f4f0 Compare August 18, 2022 11:38
@biojppm biojppm merged commit 452aedf into master Aug 18, 2022
@biojppm biojppm deleted the fix/crtp_overloads branch August 18, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeRef: const methods do not participate in overload resolution
1 participant