-
Notifications
You must be signed in to change notification settings - Fork 115
Add ConstNodeRef to enforce const correctness #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@BenjaminNavarro FYI. This is still a work-in-progress, but I'm satisfied with the mechanics and it already passes all the existing tests, so if you want you can take a look. I'm still going to try to minimize code duplication across |
Nice, didn't thought this was going to be taken care of so quickly. To minimize code duplication I guess you could have either:
I think 2. is what is used in Eigen, but that might require some CRTP to pull off. 1. is easy but some people don't like to use inheritance for these things; |
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 97.11% 97.16% +0.04%
==========================================
Files 77 78 +1
Lines 17147 17757 +610
==========================================
+ Hits 16653 17253 +600
- Misses 494 504 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
54532ca
to
2a849af
Compare
fixes #266