Skip to content

[wip] fixes for issues revealed by the YAML test suite #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 28, 2022
Merged

[wip] fixes for issues revealed by the YAML test suite #207

merged 8 commits into from
Jan 28, 2022

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Jan 25, 2022 •
edited
Loading

fixes #203
fixes #204
fixes #205

@biojppm biojppm force-pushed the events branch 3 times, most recently from 8fe43c5 to eb85e84 Compare January 27, 2022 21:13
@codecov
Copy link

codecov bot commented Jan 27, 2022 •
edited
Loading

Codecov Report

Merging #207 (cd901df) into master (c5842c2) will decrease coverage by 0.22%.
The diff coverage is 94.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   97.06%   96.83%   -0.23%     
==========================================
  Files          70       74       +4     
  Lines       14972    15355     +383     
==========================================
+ Hits        14532    14869     +337     
- Misses        440      486      +46
Impacted Files Coverage Δ
src/c4/yml/preprocess.cpp 94.87% <ø> (ø)
test/test_block_folded.cpp 100.00% <ø> (ø)
test/test_case.cpp 87.11% <ø> (ø)
test/test_json.cpp 98.27% <ø> (ø)
test/test_seq_of_map.cpp 100.00% <ø> (ø)
test/test_simple_anchor.cpp 100.00% <ø> (ø)
test/test_simple_set.cpp 100.00% <ø> (ø)
src/c4/yml/detail/parser_dbg.hpp 29.62% <29.62%> (ø)
tools/yaml_events.cpp 76.59% <88.46%> (ø)
test/test_yaml_events.cpp 94.44% <94.44%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5842c2...cd901df. Read the comment docs.

@biojppm biojppm force-pushed the events branch 2 times, most recently from 5457421 to 675c032 Compare January 28, 2022 18:09
@biojppm biojppm merged commit bd4f2c1 into master Jan 28, 2022
@biojppm biojppm deleted the events branch January 28, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@biojppm