It does make sense, but I'm not inclined to add that, as the emit overload set is already too large.

Also, you can already achieve this by using the lower level emit_json() function. Let's start from the current emitrs_json() implementation:

template<class CharOwningContainer>
substr emitrs_json(Tree const& t, size_t id, CharOwningContainer * cont)
{
    substr buf = to_substr(*cont);
    substr ret = emit_json(t, id, buf, /*error_on_excess*/false);
    if(ret.str == nullptr && ret.len > 0)
    {
        cont->resize(ret.len);
        buf = to_substr(*cont);
        ret = emit_json(t, id, buf, /*error_on_excess*/true);
    }
    return ret;
}

Using this as a starting point, and assuming we will append after cont->size(), it is easy to append by doing something like this (not tested):

template<class CharOwningContainer>
substr emitrs_json_append(Tree const& t, size_t id, CharOwningContainer * cont)
{
    size_t sz = cont->size(); // save the original container size
    cont->resize(cont->capacity()); // expand the container to its current capacity
                                    // to give us a chance to not allocate
    substr buf = to_substr(*cont); // get the full view as above
    buf = buf.sub(sz);             // but skip the original container size
                                   // (retain only at the end)
    substr ret = emit_json(t, id, buf, /*error_on_excess*/false);
    if(ret.str == nullptr && ret.len > 0)
    {
        cont->resize(sz + ret.len); // original + needed size
        buf = to_substr(*cont);
        buf = buf.sub(sz); // skip the original size
        ret = emit_json(t, id, buf, /*error_on_excess*/true);
    }
    return ret;
}
template<class CharOwningContainer>
substr emitrs_json_append(ConstNodeRef const &n, CharOwningContainer * cont)
{
    return emitrs_json_append(n.tree(), n.id(), cont);
}

HTH.

FR: Provide API for emit+append #345

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions