-
Notifications
You must be signed in to change notification settings - Fork 105
Closed
Description
Since BCFtools 1.4.1 releases have been using a 2 digits for their versions (i.e. 1.5, 1.6, 1.7 and 1.8). As such, the code in Sambamba nolonger recognises the version string generated by BCFtools.
Unless Sambamba doesn't support BCFtools > 1.4.1 I think the offending line is:
Line 109 in cbae927
auto r = regex(r"Version: 1\.\d\.\d[^\n]+"); |
I would suggest a less constrained regex and perhaps following the same path as the version detection for SAMtools:
Line 90 in cbae927
enforce(samtoolsVersion.startsWith("Version: 1."), "version " ~ samtoolsVersion ~ " of samtools is unsupported"); |
Metadata
Metadata
Assignees
Labels
No labels