Skip to content

Not recognising bcftools version >=1.5 #350

@nathanhaigh

Description

@nathanhaigh

Since BCFtools 1.4.1 releases have been using a 2 digits for their versions (i.e. 1.5, 1.6, 1.7 and 1.8). As such, the code in Sambamba nolonger recognises the version string generated by BCFtools.

Unless Sambamba doesn't support BCFtools > 1.4.1 I think the offending line is:

auto r = regex(r"Version: 1\.\d\.\d[^\n]+");

I would suggest a less constrained regex and perhaps following the same path as the version detection for SAMtools:

enforce(samtoolsVersion.startsWith("Version: 1."), "version " ~ samtoolsVersion ~ " of samtools is unsupported");

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions