refactor: resolve paths and globs from the configuration path #4823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised diagnostic limit messages for clarity, suggesting the use of `--max-diagnostics`. Adjusted configuration path handling for better consistency in various parts of the code. Updated related test snapshots to reflect these changes.
arendjr
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4813
The change is very simple, and it was done in two places.
Another change I did in this PR is reviewing a warning we print on console regarding non-printed diagnostics.
Test Plan
I tested the new logic by creating a new
biome checkscript in this repository, in the filepackages/@biomejs/biome/package.json. By default, Biome should resolve the rootbiome.json, and it should keep ignoringpackages/@biomejs/biome/configuration_schema.json. Running thecheckcommand still ignores the file.I updated the relevant snapshots.