Skip to content

Conversation

scrhartley
Copy link
Contributor

Description

The typescript type claims that the event parameter for HtmxExtension.onEvent can take Event|CustomEvent, but that's not true it can only ever receive a CustomEvent. Fix this since it's not a requirement for extensions to deal with an Event and the definition of that type doesn't have a detail property.

Testing

Ran npm run types-check, the dist script and npm run types-generate to verify the type is now correct.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the documentation Improvements or additions to documentation label May 19, 2025
@Telroshan Telroshan merged commit d2e3971 into bigskysoftware:dev May 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants