Fix type for event parameter #3317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The typescript type claims that the
event
parameter forHtmxExtension.onEvent
can takeEvent|CustomEvent
, but that's not true it can only ever receive aCustomEvent
. Fix this since it's not a requirement for extensions to deal with anEvent
and the definition of that type doesn't have adetail
property.Testing
Ran
npm run types-check
, the dist script andnpm run types-generate
to verify the type is now correct.Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded