Skip to content

Conversation

MichaelWest22
Copy link
Collaborator

Description

During loc coverage testing I found an issue where later tests would start to fail if errors happened in previous tests. This is because on two of the error paths the xhr request lock is not being removed. So I've added the end lock command to both of these paths. If a URL is verified and fails verification because it is say blocked because it is cross domain then it will not remove the lock here and any future requests by that same triggering element will fail. Also if anyhting in the onload response handler throws an error the same thing will happen and the element will be locked out of all future requests. This bug has probably not been found before because in most situations retrying would just fail again even if you could retry the request. But this change allows it to fail in a more graceful way and gives more chances for a user testing their app to retry the request multiple times to find and debug the cause.

This PR plus the other ones I just posted should get us to 100% loc coverage!!!!!

Corresponding issue:

Testing

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the bug Something isn't working label Apr 22, 2025
@Telroshan Telroshan added the ready for review Issues that are ready to be considered for merging label Apr 22, 2025
@1cg 1cg merged commit 21dc121 into bigskysoftware:dev Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants