Update testing framework to web-test-runner and improve code coverage #3273
Conversation
| @@ -68,23 +68,6 @@ describe('hx-confirm attribute', function() { | |||
| } | |||
| }) | |||
|
|
|||
| it('should allow skipping built-in window.confirm when using issueRequest', function() { | |||
There was a problem hiding this comment.
identical duplicate test removed here
| @@ -354,14 +367,18 @@ describe('Core htmx AJAX headers', function() { | |||
| htmx.off('bar', handlerBar) | |||
| }) | |||
|
|
|||
| it('should change body content on HX-Location', function() { | |||
| this.server.respondWith('GET', '/test', [200, { 'HX-Location': '{"path":"/test2", "target":"#testdiv"}' }, '']) | |||
| it.skip('should change body content on HX-Location', function(done) { | |||
There was a problem hiding this comment.
Found a bug where failed swaps and url's that fail validation cause request lock to remain blocking future requests from the same element which brake this test so we need to fix request locking
| ui: "bdd", | ||
| rootHooks: { | ||
| beforeEach(done) { | ||
| console.log(`${this?.currentTest?.parent?.title} - ${this?.currentTest?.title}`) |
There was a problem hiding this comment.
Added a custom logging hook here so that console logs are now a lot easier to read and find the test logs and errors
web-test-runner.config.mjs
Outdated
| 'test/attributes/**/*.js', | ||
| 'test/core/**/*.js' | ||
| ], | ||
| reporters: [defaultReporter()] |
There was a problem hiding this comment.
Can add summaryReporter() in here as well to dump all test names out as well But I found it doubled up the console/error logs and made it hard to find failed tests in all the spam. Can try with it added to see if you prefer this though.
There was a problem hiding this comment.
solved the summaryReporter issue i had with a workaround and made an upstream PR modernweb-dev/web#2932 to possibly resolve it properly later.
|
Tremendous, amazing work! |
The understatement of the year! |
Description
This is a big change to impalement a newer web-test-runner testing framework instead of just mocha that was introduced to idiomorph. It also includes many new tests to test all feature paths that are testable. I was able to get to 100% lines of code testing coverage by reviewing the code coverage report and by removing dead paths like IE fallbacks plus a few tricks to hide what can't be tested. However in this first PR the code coverage is only 99% because I have not included any non test changes yet. Some coverage tests I had to alter or disable to work around code bugs I identified during testing.
Corresponding issue:
Testing
Testing all the things!
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded