Skip to content

Conversation

shouya
Copy link
Contributor

@shouya shouya commented Sep 12, 2024

Description

This PR improves the documentation for hx-vals to indicate a potentially useful usage.

Corresponding issue: #2885

Testing

A test is added for this usage.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@shouya shouya marked this pull request as ready for review September 12, 2024 08:53
@Telroshan Telroshan added the documentation Improvements or additions to documentation label Sep 12, 2024
@Telroshan Telroshan changed the base branch from dev to master September 12, 2024 09:29
@Telroshan Telroshan changed the base branch from master to dev September 12, 2024 09:29
@Telroshan
Copy link
Collaborator

Well the auto rebase didn't work out that well, feel free to retarget to master for documentation changes @shouya so that they will directly appear on the website when I merge this PR 😁

@shouya shouya changed the base branch from dev to master September 12, 2024 12:49
@shouya
Copy link
Contributor Author

shouya commented Sep 12, 2024

I rebased my commits manually onto master. Hopefully they're ready now :)

@Telroshan Telroshan merged commit e6a2ea1 into bigskysoftware:master Sep 13, 2024
1 check failed
@Telroshan
Copy link
Collaborator

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants