Doc: Update oobBeforeSwap #2647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `detail.elt` and matches the event details in `htmx:oobAfterSwap`. Reference: https://github.com/bigskysoftware/htmx/blob/f9b3f883576c979b533ed657b8a7556c3b1982e4/src/htmx.js#L1443
|
I additionally removed Line 1443 in f9b3f88 |
|
The |
|
You’re right, that was an oversight on my part. I’ve reverted that change in #2649. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated oobBeforeSwap since it's out of date for two reasons:
shouldSwapalways defaults to truexhrandrequestConfigare not properties ofdetailfragmentis not documentedRegarding the
shouldSwap, I've run tests returning 300 status codes and they did not set theshouldSwapproperty to false, as was previously specified. I've also reviewed the source code with a debugger to ensure that theshouldSwapin fact never changes and is always true unless modified by the event listener.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded 😢