Skip to content

Target directory names for bench_function_over_inputs with strings #142

@robinst

Description

@robinst

Hey! First off, thanks for this great tool! I have one minor issue, here's how to reproduce:

  1. Use bench_function_over_inputs and use strings for the input such as "foo/bar"
  2. Run the benchmark
  3. Look at the file names in the target directory

Expected: Not sure what :).
Actual: The files look like this:

  • target/criterion/fun/
    • "foo/
      • bar"/

While it makes sense, it's kind of unexpected and I wonder if it might be a good idea to replace special characters such as / and " before using them in file names. What do you think?

(This came up here and I have a minimal repo to reproduce it here.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions