Skip to content

Build fails with Go 1.24 #325

@stefanb

Description

@stefanb

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

tfproviderlint and terraform-plugin-sdk Version

$ tfproviderlint -version
0.30.0

$ go mod graph | cut -d' ' -f 1 | grep terraform-plugin-sdk | uniq

Affected Check(s) or Function(s)

  • AT###

Expected Behavior

Build with Go 1.24 should succeed

Actual Behavior

Build failed.
Log from https://github.com/Homebrew/homebrew-core/actions/runs/13269964591/job/37049618249#step:3:19398 :

  ==> /opt/homebrew/Cellar/tfproviderlint/0.30.0/bin/tfproviderlint -fix /private/tmp/tfproviderlint-test-20250212-44708-kvbskr/... 2>&1
  tfproviderlint: internal error: package "log" without types was imported from "github.com/russellcardullo/terraform-provider-pingdom/pingdom [github.com/russellcardullo/terraform-provider-pingdom/pingdom.test]"
  tfproviderlint: internal error: package "log" without types was imported from "github.com/russellcardullo/terraform-provider-pingdom/pingdom"
  ==> Testing tfproviderlint (again)
  /usr/bin/env tar --extract --no-same-owner --file /Users/brew/Library/Caches/Homebrew/downloads/fccefef3f08b7a820d05ace0b85206451e84a7e7a403095e89d82eca2e9ba8ef--terraform-provider-pingdom-1.1.3.tar.gz --directory /private/tmp/homebrew-unpack-20250212-45333-pscrq4
  mv /private/tmp/homebrew-unpack-20250212-45333-pscrq4/terraform-provider-pingdom-1.1.3 /private/tmp/homebrew-test_resource-20250212-45333-lfdfof/terraform-provider-pingdom-1.1.3
  ==> /opt/homebrew/Cellar/tfproviderlint/0.30.0/bin/tfproviderlint -fix /private/tmp/tfproviderlint-test-20250212-45333-yn5xrd/... 2>&1
  tfproviderlint: internal error: package "log" without types was imported from "github.com/russellcardullo/terraform-provider-pingdom/pingdom [github.com/russellcardullo/terraform-provider-pingdom/pingdom.test]"

References

golang.org/x/tools v0.23.0

For Go 1.24 compatibility the golang.org/x/tools module should be bumped to v0.30.0 - https://github.com/golang/tools/releases/tag/v0.30.0

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestgoPull requests that update Go code

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions