Skip to content

feat: support canary for bentoml deployment apply commands #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2025
Merged

feat: support canary for bentoml deployment apply commands #5395

merged 2 commits into from
Jun 29, 2025
+44 −0

Conversation

xianml
Copy link
Contributor

@xianml xianml commented Jun 26, 2025 •
edited
Loading

What does this PR address?

bentoml deployment apply -f deployment-jtest.yaml

bento: jtest:ums23fazbcsawiru
name: jtest-lp3b
access_authorization: false
secrets: []
envs: []
services:
    Jtest:
        instance_type: cpu.small
        envs: []
        scaling:
            min_replicas: 0
            max_replicas: 1
            policy:
                scale_up_stabilization_window: 0
                scale_down_stabilization_window: 600
        config_overrides:
            traffic:
                timeout: 60
                external_queue: false
        deployment_strategy: RollingUpdate
    A:
        instance_type: cpu.small
        envs: []
        scaling:
            min_replicas: 0
            max_replicas: 1
            policy:
                scale_up_stabilization_window: 0
                scale_down_stabilization_window: 600
        config_overrides:
            traffic:
                timeout: 60
                external_queue: false
        deployment_strategy: RollingUpdate
cluster: default
canary:
  route_type: header
  route_by: X-Header
  versions:
      A:
        bento: jtest:fglup3qfm6hseiru
        weight: 50
        services:
          Jtest:
              instance_type: cpu.small
              envs: []
              scaling:
                  min_replicas: 1
                  max_replicas: 1
                  policy:
                      scale_up_stabilization_window: 0
                      scale_down_stabilization_window: 60
              config_overrides:
                  traffic:
                      timeout: 60
                      external_queue: false
              deployment_strategy: RollingUpdate
          A:
              instance_type: cpu.small
              envs: []
              scaling:
                  min_replicas: 1
                  max_replicas: 1
                  policy:
                      scale_up_stabilization_window: 0
                      scale_down_stabilization_window: 60
              config_overrides:
                  traffic:
                      timeout: 60
                      external_queue: false
              deployment_strategy: RollingUpdate

Fixes #(issue)

Before submitting:

@xianml xianml requested a review from a team as a code owner June 26, 2025 07:07
@xianml xianml requested review from parano and removed request for a team June 26, 2025 07:07
@xianml xianml changed the title Feat/canary api feat: support canary for bentoml deployment apply commands Jun 26, 2025
@xianml xianml force-pushed the feat/canary-api branch from 7451467 to 0798a9e Compare June 26, 2025 07:10
@xianml xianml changed the title feat: support canary for bentoml deployment apply commands [WIP] feat: support canary for bentoml deployment apply commands Jun 26, 2025
@github-actions GitHub Actions
Copy link

Code Coverage

Package Statements
bentoml 54.47% (9869 / 18117)
Summary 54.47% (9869 / 18117)

@xianml xianml force-pushed the feat/canary-api branch from 0798a9e to 1895aaa Compare June 27, 2025 08:28
@xianml xianml changed the title [WIP] feat: support canary for bentoml deployment apply commands feat: support canary for bentoml deployment apply commands Jun 27, 2025
@xianml xianml requested a review from bojiang June 27, 2025 09:55
@aarnphm aarnphm merged commit 53e94f5 into main Jun 29, 2025
93 of 96 checks passed
@aarnphm aarnphm deleted the feat/canary-api branch June 29, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm approved these changes

@parano parano Awaiting requested review from parano parano is a code owner automatically assigned from bentoml/bentoml-reviewers

@bojiang bojiang Awaiting requested review from bojiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xianml @aarnphm