Skip to content

fix: subclass checking for client classes #5345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

fix: subclass checking for client classes #5345

merged 1 commit into from
May 7, 2025

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fix #5343

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming requested a review from a team as a code owner May 7, 2025 01:12
@frostming frostming requested review from parano and removed request for a team May 7, 2025 01:12
Copy link

github-actions bot commented May 7, 2025

Code Coverage

Package Statements
bentoml 54.36% (9801 / 18028)
Summary 54.36% (9801 / 18028)

@aarnphm aarnphm merged commit bda7b54 into main May 7, 2025
95 of 96 checks passed
@aarnphm aarnphm deleted the fix/client-check branch May 7, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: client_cls is httpx.Client pattern does not allow customizing client_cls
2 participants