Skip to content

fix: don't restore cwd when importing service in worker #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: don't restore cwd when importing service in worker #5339

merged 1 commit into from
Apr 28, 2025

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

@frostming
fix: don't restore cwd when importing service in worker
f7393da 
Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming requested a review from a team as a code owner April 28, 2025 09:44
@frostming frostming requested review from aarnphm and removed request for a team April 28, 2025 09:44
larme
larme approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@larme larme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larme larme merged commit 67c4df5 into main Apr 28, 2025
50 of 51 checks passed
@larme larme deleted the fix/keep-cwd branch April 28, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larme larme larme approved these changes

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frostming @larme