Skip to content

fix: make sure to inherit from base image ENV #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

fix: make sure to inherit from base image ENV #5334

merged 1 commit into from
Apr 26, 2025

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Apr 26, 2025

Signed-off-by: Aaron Pham contact@aarnphm.xyz

What does this PR address?

Fixes #(issue)

Before submitting:

@aarnphm
fix: make sure to inherit from base image ENV
375a2d9 
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm requested a review from a team as a code owner April 26, 2025 18:44
@aarnphm aarnphm requested review from ssheng and removed request for a team April 26, 2025 18:44
@github-actions GitHub Actions
Copy link

Code Coverage

Package Statements
bentoml 54.35% (9796 / 18022)
Summary 54.35% (9796 / 18022)

@frostming frostming merged commit 52a8b31 into main Apr 26, 2025
51 checks passed
@frostming frostming deleted the fix/env-container branch April 26, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming approved these changes

@ssheng ssheng Awaiting requested review from ssheng ssheng is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarnphm @frostming