Skip to content

fix: make sure to use self.args in with_defaults #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

fix: make sure to use self.args in with_defaults #5324

merged 2 commits into from
Apr 17, 2025

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Apr 17, 2025 •
edited
Loading

No description provided.

@aarnphm
fix: make sure to fill in override args in with_defaults
2751b93 
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm requested a review from a team as a code owner April 17, 2025 07:57
@aarnphm aarnphm requested review from frostming and removed request for a team April 17, 2025 07:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2025 •
edited
Loading

Code Coverage

Package Statements
bentoml 54.35% (9796 / 18022)
Summary 54.35% (9796 / 18022)

@frostming
fix: correctly set args
9ff6f75 
Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming merged commit 54235e8 into main Apr 17, 2025
51 checks passed
@frostming frostming deleted the fix/make-sure-to-use-self-filed branch April 17, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarnphm @frostming