Skip to content

fix: only regard the positional arg as build ctx if it is a local dir #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix: only regard the positional arg as build ctx if it is a local dir #5322

merged 1 commit into from
Apr 17, 2025

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

@frostming frostming requested a review from a team as a code owner April 17, 2025 03:27
@frostming frostming requested review from bojiang and removed request for a team April 17, 2025 03:27
@github-actions GitHub Actions
Copy link

Code Coverage

Package Statements
bentoml 54.60% (9842 / 18024)
Summary 54.60% (9842 / 18024)

@aarnphm aarnphm merged commit 5d9f685 into main Apr 17, 2025
93 of 96 checks passed
@aarnphm aarnphm deleted the fix/build-bento-context branch April 17, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm approved these changes

@bojiang bojiang Awaiting requested review from bojiang bojiang is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frostming @aarnphm