Skip to content

fix: restore keras.save_model compatibility with Keras 3 #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 17, 2024
Merged

fix: restore keras.save_model compatibility with Keras 3 #4922

merged 6 commits into from
Aug 17, 2024

Conversation

rmarquis
Copy link
Contributor

@rmarquis rmarquis commented Aug 16, 2024 •
edited
Loading

Compatibility was lost with Keras 3. This restore the functionality when using Keras 3.4.0 or newer.

What does this PR address?

Fixes #4921

Before submitting:

@rmarquis
Fix keras.save_model compatibility with Keras 3
c34c509 
Compatibility was lost with Keras 3. This restore the functionality
when using Keras 3.4.0 or newer.

Fix #4921
@rmarquis rmarquis requested a review from a team as a code owner August 16, 2024 15:04
@rmarquis rmarquis requested review from bojiang and removed request for a team August 16, 2024 15:04
aarnphm
aarnphm reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is it possible to add a quick test for this?

@rmarquis
Copy link
Contributor Author

Sadly I'm not well versed enough in Python testing to provide an adequate test.
It seems there isn't any save_model test at the moment, so I was hoping it wouldn't be much of an issue to just provide the fix itself. Or maybe this is covered by the test_framework.py file?

If a test is absolutely necessary for this PR to be merged, I'd gladly take some pointers.

@aarnphm
Copy link
Contributor

aarnphm commented Aug 16, 2024

just need to update keras in noxfile.py to >3 or the minimum version required, then you should be good to go

@rmarquis
Copy link
Contributor Author

Gotcha, thanks! Keras 3.4 is the minimum version.

aarnphm
aarnphm reviewed Aug 17, 2024
View reviewed changes
aarnphm
aarnphm approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch.

@aarnphm aarnphm merged commit afc8647 into bentoml:main Aug 17, 2024
50 of 51 checks passed
@aarnphm aarnphm mentioned this pull request Aug 27, 2024
Closed
5 tasks
This was referenced Sep 19, 2024
Merged
Merged
@aarnphm aarnphm mentioned this pull request Feb 13, 2025
Merged
@rmarquis rmarquis mentioned this pull request Jun 24, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm approved these changes

@bojiang bojiang Awaiting requested review from bojiang bojiang is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: model saving and loading does not work with Keras 3.x model format
2 participants
@rmarquis @aarnphm