Upgrade libproc and remoteprocess to fix builds on macOS
#699
Conversation
There was a problem hiding this comment.
Thanks for fixing this!
Do we need to upgrade the remoteprocess version in Cargo.toml too ?:
Line 41 in 6ff51b6
Also can we test this out in CI? I believe we're only testing macos-13, and I believe switching this to macos-latest should do it
py-spy/.github/workflows/build.yml
Line 188 in 6ff51b6
I don't think we need to. Since it's actually a version range and the old version is compatible we just want to lock to a newer one during builds. I can look into a CI test — though I'd loosely prefer to do so separately because I have to make every change on top of this pull request then rebase onto |
There was a problem hiding this comment.
I don't think we need to. Since it's actually a version range and the old version is compatible we just want to lock to a newer one during builds.
I learned something new today =) .
|
I don't think adding test coverage there will make a difference — that looks like testing the pre-built wheels whereas this failure occurred while building. We do builds on |
Closes #596
Closes #651
Builds on macOS 13+ are failing because these dependencies are out of date.
I ran:
The first was necessary to unblock the
libprocupgrade. Now,cargo buildsucceeds on my machine.