Find exact match #141
Merged
Find exact match #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-uk
reviewed
Jul 11, 2025
There was a problem hiding this comment.
Thank you so much for the PR
I think we can simplify this even more!
I'll admit I let AI assistant auto create this function and wasn't paying attention! The logic should be a simple exact match not some substring or partial
I tested this with the same pod & service names you have and it works now
benc-uk
reviewed
Jul 11, 2025
ba0056b to
7d4a0a5
Compare
|
Changed the branch history and force pushed, since it gives a cleaner fix:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
The
findResByNamefunction returned the first resource whose name contained the search string.Now it instead returns the shortest-named resource whose name contains the search string. The assumption is that if there are multiple matches, one is a longer name, that coincidentally also contains the search string, but is not the intended resource. The shortest one is the actual intended match.
There may still be edge cases where this too fails. Especially when you get creative with kubernetes name generation.