Skip to content

Allow disabling both load balancer and ingress #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Allow disabling both load balancer and ingress #77

merged 1 commit into from
Oct 30, 2021

Conversation

shivjm
Copy link
Contributor

@shivjm shivjm commented Sep 18, 2021

Preserves the default behaviour of creating a load balancer, but allows disabling it with loadBalancer.enabled: false. Also changes the load balancer IP parameter from loadBalancerIP to loadBalancer.IP.

Closes #71

Preserves the default behaviour of creating a load balancer, but
allows disabling it with `loadBalancer.enabled: false`. Also changes
the load balancer IP parameter from `loadBalancerIP` to
`loadBalancer.IP`.

Closes #71
Copy link
Owner

@benc-uk benc-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@benc-uk benc-uk merged commit b101254 into benc-uk:master Oct 30, 2021
@shivjm shivjm deleted the allow-disabling-both-load-balancer-and-ingress branch October 30, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Helm] Don't use LoadBalancer service type by default (work behind a proxy)
2 participants