Skip to content

switch expression formatting adds odd newlines #1620

@marcinjahn

Description

@marcinjahn

Input:

    public static int GetMetaCodesLimit(SearchRepositoryRequest request) =>
        request switch
        {
            _ when request.SearchCriteria.ContextConfiguration.IsFeatureEnabled(
                    FeatureFlags.UseDynamicSearchFallbackInPackagesApi
                ) => MAX_METACODES_COUNT_FOR_INV_DYNAMIC_SEARCH,
            _ when request.SearchCriteria.Filters.HasPriceFiltering() =>
                MAX_METACODES_COUNT_FOR_PRICE_FILTER,
            _ when request.SortingConfiguration.Sorting.SortBy
                    is Portfolio.Common.Models.SortBy.TotalPrice =>
                MAX_METACODES_COUNT_FOR_TOTAL_PRICE_SORTING,
            _ when request.PagingConfiguration.PageSize
                    < MAX_PAGE_SIZE_FOR_NON_PRICE_SORTED_VARIABLE_METACODES_COUNT =>
                GetVariablePageSizeForNonPriceSorting(request.PagingConfiguration.PageSize),
            _ => MAX_METACODES_COUNT_FOR_NON_PRICE_SORTING,
        };

Output:

    public static int GetMetaCodesLimit(SearchRepositoryRequest request) =>
        request switch
        {
            _
                when request.SearchCriteria.ContextConfiguration.IsFeatureEnabled(
                    FeatureFlags.UseDynamicSearchFallbackInPackagesApi
                ) => MAX_METACODES_COUNT_FOR_INV_DYNAMIC_SEARCH,
            _ when request.SearchCriteria.Filters.HasPriceFiltering() =>
                MAX_METACODES_COUNT_FOR_PRICE_FILTER,
            _
                when request.SortingConfiguration.Sorting.SortBy
                    is Portfolio.Common.Models.SortBy.TotalPrice =>
                MAX_METACODES_COUNT_FOR_TOTAL_PRICE_SORTING,
            _
                when request.PagingConfiguration.PageSize
                    < MAX_PAGE_SIZE_FOR_NON_PRICE_SORTED_VARIABLE_METACODES_COUNT =>
                GetVariablePageSizeForNonPriceSorting(request.PagingConfiguration.PageSize),
            _ => MAX_METACODES_COUNT_FOR_NON_PRICE_SORTING,
        };

Expected behavior:

I'd expect to get the same thing as in the input really.
The newlines added in the csharpier output do not help in anything.

    public static int GetMetaCodesLimit(SearchRepositoryRequest request) =>
        request switch
        {
            _ when request.SearchCriteria.ContextConfiguration.IsFeatureEnabled(
                    FeatureFlags.UseDynamicSearchFallbackInPackagesApi
                ) => MAX_METACODES_COUNT_FOR_INV_DYNAMIC_SEARCH,
            _ when request.SearchCriteria.Filters.HasPriceFiltering() =>
                MAX_METACODES_COUNT_FOR_PRICE_FILTER,
            _ when request.SortingConfiguration.Sorting.SortBy
                    is Portfolio.Common.Models.SortBy.TotalPrice =>
                MAX_METACODES_COUNT_FOR_TOTAL_PRICE_SORTING,
            _ when request.PagingConfiguration.PageSize
                    < MAX_PAGE_SIZE_FOR_NON_PRICE_SORTED_VARIABLE_METACODES_COUNT =>
                GetVariablePageSizeForNonPriceSorting(request.PagingConfiguration.PageSize),
            _ => MAX_METACODES_COUNT_FOR_NON_PRICE_SORTING,
        };

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions