Skip to content

fix: natspec parser and function returns validation #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 22, 2025
Merged

fix: natspec parser and function returns validation #37

merged 7 commits into from
Feb 22, 2025

Conversation

beeb
Copy link
Owner

@beeb beeb commented Feb 22, 2025 •
edited
Loading

This PR adds snapshot testing and allowed to uncover two bugs:

  • A logical error in function returns validation, where missing natspec didn't cause a diagnostic if the function had no a parameters but some return values
  • A parser improvement to accept an arbitrarily large number of forward slashes (>2) at the start of single-line comment

@beeb beeb changed the title test: add snapshot testing fix: natspec parser and function returns validation Feb 22, 2025
@beeb beeb merged commit f1c0d5f into main Feb 22, 2025
12 checks passed
@beeb beeb deleted the snapshot-testing branch February 22, 2025 18:12
@beeb-release-plz beeb-release-plz bot mentioned this pull request Feb 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beeb