Skip to content

chore(deps): update deps #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2025
Merged

chore(deps): update deps #117

merged 2 commits into from
Aug 27, 2025

Conversation

beeb
Copy link
Owner

@beeb beeb commented Aug 27, 2025

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #117 will not alter performance

Comparing update-deps (77afd2a) with main (6c93c22)

Summary

✅ 25 untouched benchmarks

@beeb
Copy link
Owner Author

beeb commented Aug 27, 2025 •
edited
Loading

@DaniPopes this might be of interest to you. I see a big regression between solar 0.1.5 and 0.1.6.

Real use-case benchmark confirms this (before, the solar version was 2x faster than the slang version):

Benchmark 1: lintspec src --compact --skip-version-detection
  Time (mean ± σ):      45.2 ms ±   1.9 ms    [User: 320.1 ms, System: 48.1 ms]
  Range (min … max):    41.0 ms …  51.0 ms    64 runs

  Warning: Ignoring non-zero exit code.

Benchmark 2: lintspec-solar src --compact
  Time (mean ± σ):     123.6 ms ±  10.7 ms    [User: 76.1 ms, System: 272.5 ms]
  Range (min … max):   101.0 ms … 150.6 ms    24 runs

  Warning: Ignoring non-zero exit code.

Summary
  lintspec src --compact --skip-version-detection ran
    2.74 ± 0.26 times faster than lintspec-solar src --compact

While on main I get:

lintspec-solar src --compact ran
    2.21 ± 0.14 times faster than lintspec src --compact --skip-version-detection

EDIT: the behavior of Session::enter changed in the latest release, which created a rayon pool for each file. Moving to enter_sequential restores performance.

@beeb beeb mentioned this pull request Aug 27, 2025
Closed
@beeb beeb merged commit d728fb1 into main Aug 27, 2025
19 checks passed
@beeb beeb deleted the update-deps branch August 27, 2025 08:31
This was referenced Aug 18, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beeb