fix: additional solar discrepency fixes #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simon-something
commented
May 27, 2025
- set commit hash for the solar github import (temp-fix - waiting for Solar release)
- fix multikeyword type span for unnamed var
CodSpeed Performance ReportMerging #90 will not alter performanceComparing Summary
|
beeb
added a commit
that referenced
this pull request
Jun 3, 2025
* test(solar): add comparison test * refactor(solar): move conversion function into visitor * fix(solar): populate nested spans inside of definitions * refactor(solar): if-chain into match * feat(slang): improve end of span * fix: remove print * fix: end of function * fix(slang): end of span for function declaration * fix: solar span too tight (#87) * fix: extend doc span to item span * feat: bump solar version to use fn header span * chore: named assert * fix: identifiers span * chore: cleanup * fix: fn-like body span * fix: rn newline from multiline fn header span * fix: additional solar discrepency fixes (#90) * chore: commit hash for solar dep * fix: multi kw unnamed return span * chore: cleanup dbg * fix(slang): unnamed return span * fix(solar): remove temp fix for Windows EOL (#91) * chore: rm temp fix for windows eol * chore: solar v bump --------- Co-authored-by: drgorillamd <83670532+drgorillamd@users.noreply.github.com> --------- Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com> Co-authored-by: drgorillamd <83670532+drgorillamd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.