fix(solar): differences in offsets/spans #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #86 will degrade performances by 26.15%Comparing Summary
Benchmarks breakdown
|
* fix: extend doc span to item span * feat: bump solar version to use fn header span * chore: named assert * fix: identifiers span * chore: cleanup * fix: fn-like body span * fix: rn newline from multiline fn header span
* chore: commit hash for solar dep * fix: multi kw unnamed return span * chore: cleanup dbg
|
Now waiting for a new solar release. Perf regression on interface test is normal as the test case changed. |
* chore: rm temp fix for windows eol * chore: solar v bump --------- Co-authored-by: drgorillamd <83670532+drgorillamd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several inconsistencies in text span for various diagnostics were identified by diff-testing the solar and slang implementations. This PR fixes them and also improves performance of the solar parser by only iterating once over the source text to determine the utf16 offsets.