-
Notifications
You must be signed in to change notification settings - Fork 2
Update to more modern pyproject.toml and resolve test errors #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to more modern pyproject.toml and resolve test errors #4
Conversation
WOAH. Phenomenal! Stunning! And other commendable superlatives! Please volunteer your awesomeness for the main @beartype codebase, too. I'm begging you here... Very well. I'll stop begging. This PR is fantastic. I see only a few issues – mostly negligible, thankfully:
# In "pyproject.toml":
[tool.pytest.ini_options]
pythonpath = "src/" # In "tox.ini":
[testenv]
commands = pytest ... -o pythonpath= ...maybe? Worth a try, anyway. Truly, CI is mind-boggling. 🥴 |
$ hatch build
$ cd dist
$ cp ipython_beartype-0.1.0-py3-none-any.whl ipython_beartype-0.1.0-py3-none-any.zip
$ unzip ipython_beartype-0.1.0-py3-none-any.zip
Archive: ipython_beartype-0.1.0-py3-none-any.zip
inflating: ipython_beartype/__init__.py
inflating: ipython_beartype/py.typed <----- Looks like it is in here
inflating: ipython_beartype-0.1.0.dist-info/METADATA
inflating: ipython_beartype-0.1.0.dist-info/WHEEL
inflating: ipython_beartype-0.1.0.dist-info/licenses/LICENSE
inflating: ipython_beartype-0.1.0.dist-info/RECORD
|
Oh, right. I forgot that Hatch bundles
Truer words were never spoken.
Superb. Your vigorous finger-crossing and hard work has paid off. Tests pass. Congrats, @ntjohnson1! I'll give @tusharsadhwani a day or two to chime in before merging this. But... this certainly looks superb from my end. I can hardly hold back the joyful tears anymore. 🥹 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This should close #1 and makes steps towards #2.