Upgrade Electron to v32 #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
morishin
commented
Aug 4, 2025
- Electron 14 -> 32
- Node.js 16 -> 22
- Typescript 4.5 -> 5.5
Major changes: - Electron: v14.2.9 → v32.2.0 (18 major version upgrade) - electron-builder: v23.6.0 → v25.1.8 - electron-mocha: v11.0.2 → v12.3.0 - spectron: v14.0.0 → v15.0.0 Breaking changes handled: - Added preload script for secure IPC communication - Updated webpack config for preload script build - Fixed render-process-gone event handling - Addressed TypeScript compatibility issues - Resolved setImmediate access in renderer process 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Updates: - Volta Node.js version: 16.20.2 → 22.16.0 - @types/node: 12.12.12 → ^22.0.0 - TypeScript: ^4.5.5 → ^5.5.0 - ts-node: 5.0.1 → ^10.9.0 - @typescript-eslint/eslint-plugin: ^5.10.0 → ^7.0.0 - @typescript-eslint/parser: ^5.10.0 → ^7.0.0 All tests pass and application starts successfully with Node.js 22. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update test.yml: Node.js 16 → 22 - Update prepare_release.yml: Node.js 16 → 22 - Update commented integration test workflow to Node.js 22 This aligns CI/CD environments with the updated local development environment. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixes:
- Fix TS2872 in Setting.ts: Remove unnecessary || {} for object spread
- Fix TS2344 in Store.ts: Add Record<string, any> constraint to generics
- Fix TS2344 in Container.ts: Add Record<string, any> constraint to generics
- Update ESLint to v8.56.0 for compatibility with @typescript-eslint v7
All TypeScript compilation, ESLint, Prettier checks pass.
All tests pass and application builds successfully.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
The preload script was trying to require a non-existent module path "../../app/development/out/app" which caused webpack build failures in CI. Changes: - Remove problematic require function from nodeAPI - Simplify preload script to only expose necessary APIs - Reduce preload bundle size from 270KB to 3.97KB (dev) / 1.05KB (prod) - Fix webpack compilation error in production builds The require functionality was not actually needed, as the application uses the standard HTML script loading mechanism. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.