Skip to content

Add desktop notification for query completion when app is in background #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 1, 2025
Merged

Add desktop notification for query completion when app is in background #277

merged 4 commits into from
Aug 1, 2025

Conversation

morishin
Copy link
Collaborator

@morishin morishin commented Aug 1, 2025 •
edited
Loading

Summary

  • Adds desktop notifications when query execution completes (both success and failure)
  • Only shows notifications when the application window is not focused (in background)
  • Includes relevant execution details: runtime and row count for successful queries, error messages for failed queries

Implementation

  • Added IPC communication between renderer and main process when queries complete
  • Used Electron's built-in Notification API for cross-platform desktop notifications
  • Implemented window focus detection to avoid showing notifications when app is active

Test plan

  • Run a query while app is focused - should not show notification
  • Run a query while app is in background - should show appropriate notification
  • Test both successful and failed query scenarios
    • failure
  • Verify notification content includes expected details (runtime, row count, error messages)

🤖 Generated with Claude Code

morishin and others added 3 commits August 1, 2025 11:20
@morishin
Claude Code
dfd6522
@morishin @claude
Add desktop notification for query completion when app is in background
61d5d73 
- Send IPC message when query execution completes (success/failure)
- Display notification only when app window is not focused
- Include execution time and row count for successful queries
- Show error message excerpt for failed queries

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@morishin
Merge branch 'master' into notification
c4e74cb
morishin
morishin commented Aug 1, 2025
View reviewed changes
@morishin morishin merged commit 5abaaea into master Aug 1, 2025
2 checks passed
@morishin morishin deleted the notification branch August 1, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@morishin