Load a query from DB whenever select or duplicate it #261

morishin · 2023-05-31T03:07:37Z

Problem

#256 makes a bug. No data source is selected when user select a query from the list because of it.

Reason

That makes it get not only id and title but also body and created_at for showing the query list.

Lines 33 to 34 in b64eb49

    
           static async getAll(): Promise<Pick<QueryType, "id" | "title" | "body" | "createdAt">[]> { 
        
             const results = await connection.all("select id, title, body, createdAt from queries order by createdAt desc");

But selectQuery does not refetch a query from DB when body is not empty. Therefore the properties of the selected query other than the above properties (id, title, body, created_at) does not appear in the query details screen.

bdash/src/renderer/pages/Query/QueryAction.ts

Lines 47 to 55 in b64eb49

    
           async selectQuery(query: QueryType): Promise<void> { 
        
             const id = query.id; 
        
             if (query.body === undefined) { 
        
               const query = await Database.Query.find(id); 
        
               dispatch("selectQuery", { id, query }); 
        
             } else { 
        
               dispatch("selectQuery", { id, query: {} }); 
        
             } 
        
           },

Solution

Always refetch a query from DB when a user make actions (select, duplicate) on the query.

Load a query from DB whenever select or duplicate it

4ad7fdf

morishin self-assigned this May 31, 2023

hokaccha approved these changes May 31, 2023

View reviewed changes

morishin merged commit 28a6931 into bdash-app:master May 31, 2023

morishin deleted the always-load-query-from-db branch May 31, 2023 03:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Load a query from DB whenever select or duplicate it #261

Load a query from DB whenever select or duplicate it #261

Uh oh!

morishin commented May 31, 2023

Uh oh!

Uh oh!

	static async getAll(): Promise<Pick<QueryType, "id" \| "title" \| "body" \| "createdAt">[]> {
	const results = await connection.all("select id, title, body, createdAt from queries order by createdAt desc");

	async selectQuery(query: QueryType): Promise<void> {
	const id = query.id;
	if (query.body === undefined) {
	const query = await Database.Query.find(id);
	dispatch("selectQuery", { id, query });
	} else {
	dispatch("selectQuery", { id, query: {} });
	}
	},

Load a query from DB whenever select or duplicate it #261

Load a query from DB whenever select or duplicate it #261

Uh oh!

Conversation

morishin commented May 31, 2023

Problem

Reason

Solution

Uh oh!

Uh oh!