Skip to content

Conversation

lcoombe
Copy link
Member

@lcoombe lcoombe commented Sep 17, 2024

  • Add model trained with v3.2.1 code
  • Bump version numbers
  • Update README.md to point to new pre-trained model

* Add model trained with v3.2.1 code
* Bump version numbers
* Update README.md to point to new pre-trained model
@lcoombe lcoombe merged commit edc8f8b into master Sep 17, 2024
@lcoombe lcoombe deleted the add_model branch September 17, 2024 19:25
fgvieira pushed a commit to snakemake/snakemake-wrappers that referenced this pull request Feb 12, 2025
…ersion of nanosim in the wrapper (#3648)

<!-- Ensure that the PR title follows conventional commit style (<type>:
<description>)-->
<!-- Possible types are here:
https://github.com/commitizen/conventional-commit-types/blob/master/index.json
-->

This pull request leverages two things:

1. There are recent pre-trained models, generated with `nanosim` `3.2`,
which should be compatible with the latest versions of `nanosim` itself.
These come from these two pull requests:
  * bcgsc/NanoSim#224
  * bcgsc/NanoSim#238
2. In addition, we could patch the bioconda recipe for `nanosim` a bit
and update it to the latest version:
  * bioconda/bioconda-recipes#53528

With `scikit-learn` fixed to the version used for training those recent
models, we can now update this wrapper to use these latest models for
testing and the wrapper should in general work with those recent models.
 

### QC
<!-- Make sure that you can tick the boxes below. -->

* [x] I confirm that I have followed the [documentation for contributing
to
`snakemake-wrappers`](https://snakemake-wrappers.readthedocs.io/en/stable/contributing.html).

While the contributions guidelines are more extensive, please
particularly ensure that:
* [x] `test.py` was updated to call any added or updated example rules
in a `Snakefile`
* [x] `input:` and `output:` file paths in the rules can be chosen
arbitrarily
* [x] wherever possible, command line arguments are inferred and set
automatically (e.g. based on file extensions in `input:` or `output:`)
* [x] temporary files are either written to a unique hidden folder in
the working directory, or (better) stored where the Python function
`tempfile.gettempdir()` points to
* [x] the `meta.yaml` contains a link to the documentation of the
respective tool or command under `url:`
* [x] conda environments use a minimal amount of channels and packages,
in recommended ordering


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Expanded simulation workflows with additional model inputs and updated
training datasets across genome, transcriptome, and metagenome
processes.

- **Chores**
- Upgraded `nanosim` dependency to version 3.2.3 and removed outdated
compatibility constraints for `numpy`.

- **Tests**
- Revised simulation output references in tests to align with the new
dataset paths and updated directory structures.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant