Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/rules_apple
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.1.0
Choose a base ref
...
head repository: bazelbuild/rules_apple
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.1.1
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 21, 2025

  1. Fix bugs with macOS test runner (#2754) 

    Fixes two major issues with the `macos_unit_test` runner

- Tests were always passing because:

```
xcodebuild <...> 2>&1 | tee -i "$testlog" \
    || test_exit_code=$?
```

Without `pipefail` means the exit code of the `xcodebuild` command is
dropped. This meant as of
#2649 all
`macos_unit_test` were always passing even when tests failed 🙈

- Warning when running `xcodebuild`:

```
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:arm64e, id:00006031-001851843684001C, name:My Mac }
{ platform:macOS, arch:arm64, id:00006031-001851843684001C, name:My Mac }
{ platform:macOS, arch:x86_64, id:00006031-001851843684001C, name:My Mac }
{ platform:macOS, arch:arm64e, variant:Mac Catalyst, id:00006031-001851843684001C, name:My Mac }
{ platform:macOS, arch:arm64, variant:Mac Catalyst, id:00006031-001851843684001C, name:My Mac }
{ platform:macOS, arch:x86_64, variant:Mac Catalyst, id:00006031-001851843684001C, name:My Mac }
{ platform:macOS, arch:arm64e, variant:DriverKit, id:00006031-001851843684001C, name:My Mac }
{ platform:macOS, arch:arm64, variant:DriverKit, id:00006031-001851843684001C, name:My Mac }
{ platform:macOS, arch:arm64e, variant:Designed for [iPad,iPhone], id:00006031-001851843684001C, name:My Mac }
{ platform:macOS, arch:arm64, variant:Designed for [iPad,iPhone], id:00006031-001851843684001C, name:My Mac }
```

The fix here is to specify `variant=macos` and `arch` so that xcodebuild
always picks the right destination.
    @luispadron
    luispadron authored Jul 21, 2025
    Configuration menu
    Copy the full SHA
    724e402 View commit details
    Browse the repository at this point in the history
Loading