Remove shadow analyzer from TOOLS_NOGO #4344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0eb20df to
f20861e
Compare
|
Looks like we are relying on this particular analyzer in tests. How about we migrate them to https://pkg.go.dev/golang.org/x/tools@v0.33.0/go/analysis/passes/assign? |
690772a to
c935bb9
Compare
The shadow analyzer issues many false positives which are not in keeping with Go best practices. Even the upstream documentation for this analyzer admits this and claims that it is experimental. It should not be included in the default list of analyzers provided by nogo (users can still opt-in to it if they want it).
fmeum
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
The shadow analyzer issues many false positives which are not in keeping with Go best practices. Even the upstream documentation for this analyzer admits this and claims that it is experimental. It should not be included in the default list of analyzers provided by nogo (users can still opt-in to it if they want it).
Which issues(s) does this PR fix?
Fixes #4340
Other notes for review