Skip to content

Conversation

sluongng
Copy link
Contributor

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Let user change the compilation mode with go_cross_binary.
This is useful to force a opt mode for a deployment or packaging
purposes.

Which issues(s) does this PR fix?

Other notes for review

Let user change the compilation mode with go_cross_binary.
This is useful to force a opt mode for a deployment or packaging
purposes.
Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to reject this as go_cross_binary shouldn't grow too much (we should recommend extensions/with_cfg instead), but compilation_mode does meet the bar in terms of simplicity and usefulness.

Could you update the docs to fix CI?

@sluongng
Copy link
Contributor Author

docs should be updated now

@fmeum fmeum merged commit 185ecb7 into bazel-contrib:master Apr 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants